On Thu, 2016-10-13 at 20:45 +0530, Purushottam Kushwaha wrote:

This commit enhances the current beacon interval validation to also
consider
the "radar_detect" and "num_different_channels".

Move calculation of GCD for all beaconing interfaces to
"cfg80211_iter_combinations".

Rename "cfg80211_validate_beacon_int" to
"cfg80211_validate_beacon_combination"
as the validation considers other parameters.

So this was better, but I think we're mixing too many things in here.

I'm not convinced, for example, that checking if radar is required is
really the right thing, it might still be enabled even if it's not
required (any more, regulatory may change)?

Not that I don't think that's a worthwhile goal - moving more of the
data/calculation back into cfg80211 - but I don't think it should be
mixed in here.

I've just sent out a few patches that, I think, implement the necessary
validation for just the beacon intervals, without all this extra
baggage. Please take a look and let me know what you think.

johannes