[PATCH 0774/1285] Replace numeric parameter like 0444 with macro
From: Baole Ni <hidden>
Date: 2016-08-02 15:44:40
Also in:
lkml, netdev
Subsystem:
intel pro/wireless 2100, 2200bg, 2915abg network connection support, the rest · Maintainers:
Stanislav Yakovlev, Linus Torvalds
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <redacted> Signed-off-by: Baole Ni <redacted> --- drivers/net/wireless/intel/ipw2x00/ipw2100.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2100.c b/drivers/net/wireless/intel/ipw2x00/ipw2100.c
index bfa542c..e94e000 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2100.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2100.c@@ -197,11 +197,11 @@ static struct ipw2100_fw ipw2100_firmware; #endif #include <linux/moduleparam.h> -module_param(debug, int, 0444); -module_param_named(mode, network_mode, int, 0444); -module_param(channel, int, 0444); -module_param(associate, int, 0444); -module_param(disable, int, 0444); +module_param(debug, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(mode, network_mode, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(channel, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(associate, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(disable, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "debug level"); MODULE_PARM_DESC(mode, "network mode (0=BSS,1=IBSS,2=Monitor)");
--
2.9.2