[PATCH 0800/1285] Replace numeric parameter like 0444 with macro
From: Baole Ni <hidden>
Date: 2016-08-02 15:36:02
Also in:
lkml, netdev
Subsystem:
realtek wireless driver (rtlwifi family), the rest · Maintainers:
Ping-Ke Shih, Linus Torvalds
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <redacted> Signed-off-by: Baole Ni <redacted> --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c
index 2101793..530b692 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/sw.c@@ -387,15 +387,15 @@ MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Realtek 8723BE 802.11n PCI wireless"); MODULE_FIRMWARE("rtlwifi/rtl8723befw.bin"); -module_param_named(swenc, rtl8723be_mod_params.sw_crypto, bool, 0444); -module_param_named(debug, rtl8723be_mod_params.debug, int, 0444); -module_param_named(ips, rtl8723be_mod_params.inactiveps, bool, 0444); -module_param_named(swlps, rtl8723be_mod_params.swctrl_lps, bool, 0444); -module_param_named(fwlps, rtl8723be_mod_params.fwctrl_lps, bool, 0444); -module_param_named(msi, rtl8723be_mod_params.msi_support, bool, 0444); +module_param_named(swenc, rtl8723be_mod_params.sw_crypto, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(debug, rtl8723be_mod_params.debug, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(ips, rtl8723be_mod_params.inactiveps, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(swlps, rtl8723be_mod_params.swctrl_lps, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(fwlps, rtl8723be_mod_params.fwctrl_lps, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(msi, rtl8723be_mod_params.msi_support, bool, S_IRUSR | S_IRGRP | S_IROTH); module_param_named(disable_watchdog, rtl8723be_mod_params.disable_watchdog, - bool, 0444); -module_param_named(ant_sel, rtl8723be_mod_params.ant_sel, int, 0444); + bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(ant_sel, rtl8723be_mod_params.ant_sel, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(swenc, "Set to 1 for software crypto (default 0)\n"); MODULE_PARM_DESC(ips, "Set to 0 to not use link power save (default 1)\n"); MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 0)\n");
--
2.9.2