[PATCH 0796/1285] Replace numeric parameter like 0444 with macro
From: Baole Ni <hidden>
Date: 2016-08-02 15:30:51
Also in:
lkml, netdev
Subsystem:
realtek wireless driver (rtlwifi family), the rest · Maintainers:
Ping-Ke Shih, Linus Torvalds
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <redacted> Signed-off-by: Baole Ni <redacted> --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
index c6e09a1..162f60a 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/sw.c@@ -369,11 +369,11 @@ MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Realtek 8192DE 802.11n Dual Mac PCI wireless"); MODULE_FIRMWARE("rtlwifi/rtl8192defw.bin"); -module_param_named(swenc, rtl92de_mod_params.sw_crypto, bool, 0444); -module_param_named(debug, rtl92de_mod_params.debug, int, 0444); -module_param_named(ips, rtl92de_mod_params.inactiveps, bool, 0444); -module_param_named(swlps, rtl92de_mod_params.swctrl_lps, bool, 0444); -module_param_named(fwlps, rtl92de_mod_params.fwctrl_lps, bool, 0444); +module_param_named(swenc, rtl92de_mod_params.sw_crypto, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(debug, rtl92de_mod_params.debug, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(ips, rtl92de_mod_params.inactiveps, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(swlps, rtl92de_mod_params.swctrl_lps, bool, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(fwlps, rtl92de_mod_params.fwctrl_lps, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(swenc, "Set to 1 for software crypto (default 0)\n"); MODULE_PARM_DESC(ips, "Set to 0 to not use link power save (default 1)\n"); MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 1)\n");
--
2.9.2