On Sun, 2016-01-03 at 08:00 +0100, SF Markus Elfring wrote:

quoted

quoted

        r = 0;
-
-err:
+free_reply:
        kfree(reply);
+free_cmd:
        kfree(cmd);
-

Why are you deleting the two blank lines here?

Can they be unnecessary at this source code place
according to the Linux coding style convention?

As far as I know, there's no linux specific accepted
convention for blank lines preceding labels.

My personal preference is for a blank line before a
new block, but not before the second and subsequent
labels in an error handling block.