# Re: \[PATCH 1/6\] lib / string\_helpers: clean up test suite

- From: Andy Shevchenko \<andriy.shevchenko@linux.intel.com\>
- Date: 2014-07-03 09:35:19 
- List: linux-wireless
- Page: https://ratatoskr.run/linux-wireless/2014/07/4286040
- Thread: https://ratatoskr.run/linux-wireless/2014/07/4285331/t.md

```text
On Wed, 2014-07-02 at 14:54 -0700, Andrew Morton wrote:
> On Wed,  2 Jul 2014 16:20:24 +0300 Andy Shevchenko [ref] wrote:

[]

> > +	pr_err("Test '%s' failed: flags = %u\n", name, flags);
> > +
> > +	print_hex_dump(KERN_WARNING, "Input: ", DUMP_PREFIX_NONE, 16, 1,
> > +		       in, p, true);
> > +	print_hex_dump(KERN_WARNING, "Expected: ", DUMP_PREFIX_NONE, 16, 1,
> > +		       out_test, q_test, true);
> > +	print_hex_dump(KERN_WARNING, "Got: ", DUMP_PREFIX_NONE, 16, 1,
> > +		       out_real, q_real, true);
> 
> Seems strange to mix KERN_ERR and KERN_WARNING.  The code's always been
> that way, but maybe it can be improved.

Will fix this.


-- 
Andy Shevchenko [ref]
Intel Finland Oy

```
