2 messages, 2 authors, 2012-08-06 · open the first message on its own page
From: Christopher Sacchi <hidden>
Date: 2012-08-06 02:02:24
The source file needed a change that was told in the description to know that the #include needed to be fixed, and the function changed another value to 0 (yes) in the description (that said FIXME.) Thanks, -- Christopher
From: Julian Calaby <hidden>
Date: 2012-08-06 02:17:08
Hi Christopher, On Mon, Aug 6, 2012 at 12:02 PM, Christopher Sacchi [off-list ref] wrote:
The source file needed a change that was told in the description to know that the #include needed to be fixed, and the function changed another value to 0 (yes) in the description (that said FIXME.)
This still doesn't explain everything. I'm guessing that the changes you're making fix some bug you've seen. Your patch description, which should be in the *same* email as the correctly formatted patch itself needs to tell us what bug this fixes, including any error messages that appear, and do so clearly and sensibly so that the maintainer (Johannes) can quickly and easily evaluate whether this patch is worth accepting. You also need to format it correctly so that if he decides to accept it, he can import it directly using git. To do that, you need to send a *single* email that contains the description and the patch, following the rules here: https://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=blob;f=Documentation/SubmittingPatches;h=c379a2a6949f1c1cac04fb6f185c633512f37061;hb=HEAD Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/