Re: [PATCH] mwl8k: Add 0x2a02 PCI device-id (Marvell 88W8361)
From: Dan Williams <hidden>
Date: 2012-05-07 16:09:07
Also in:
lkml, netdev
On Tue, 2012-05-01 at 14:51 +0200, Lennert Buytenhek wrote:
On Sun, Apr 29, 2012 at 12:25:21AM +0200, Sedat Dilek wrote:quoted
quoted
On 1st sight, logs look fine: [21:52:52] <lautriv> [ 6.050967] ieee80211 phy0: 88w8361p v4, 00173f3bdde3, STA firmware 2.1.4.25 But WLAN connection is not that fast and stable as lautriv reports (several abnormalities were observed). I requested a tarball which includes: * dmesg (Linux-3.3.3) * e_n_a (/etc/network/interfaces) * ifconfig output * iwconfig output * iw_phy output * ps_axu (WPA) output lautriv will be so kind to be around on #linux-wireless/Freenode the next days (UTC+2: German/Swiss local-time). Just ping him. Hope you have fun, together! - Sedat -A new tarball from lautriv with same outputs as before, but now tested with Linux-3.4-rc4.The output looks good enough for me to ACK adding the PCI ID. Can the firmware being used here be submitted to the linux-firmware git tree?
So Marvell sent John a driver for TopDog a long time ago, which he put up on kernel.org. That driver was reworked by Louis and put up in a git tree, but both were lost to the kernel.org hack. I have git backups of both git trees. I put Louis' cleanup here: http://people.redhat.com/dcbw/mrvl_cb82.tar.bz2 That driver (mrvl_cb82) has the following PCI IDs: static const struct pci_device_id mwl_id_tbl[] __devinitdata = { { PCI_VDEVICE(MARVELL, 0x2a02), 0 }, { PCI_VDEVICE(MARVELL, 0x2a03), 1 }, { PCI_VDEVICE(MARVELL, 0x2a06), 2 }, { PCI_VDEVICE(MARVELL, 0x2a07), 3 }, { PCI_VDEVICE(MARVELL, 0x2a04), 4 }, { PCI_VDEVICE(MARVELL, 0x2a08), 5 }, { PCI_VDEVICE(MARVELL, 0x2a0a), 6 }, { PCI_VDEVICE(MARVELL, 0x2a0b), 7 }, { PCI_VDEVICE(MARVELL, 0x2a0c), 8 }, { 0 } }; and supposedly works for CB82 + CB85. The firmware helper for CB82 looks pretty close to the mwl8k one. The firmware API exposed by mrvl_cb82 looks very close to mwl8k actually. I only checked the HostCmd bits, not the structures, so I would expect a few differences. There are some commands that mwl8k exposes that mrvl_cb82 does not and vice versa, but I'm not sure if the drivers actually use those commands. Hope this helps. Dan