Re: [PATCH V2] rtl8192cu: Fix WARNING on suspend/resume
From: Larry Finger <hidden>
Date: 2012-01-14 20:19:19
Also in:
lkml
John, Please drop the patch with this subject. I think I can do a better job than this. Larry Commit message: ============================================= A recent LKML thread (http://lkml.indiana.edu/hypermail/linux/kernel/1112.3/00965.html) discusses warnings that occur during a suspend/resume cycle. The driver attempts to read the firmware file before userspace is ready, leading to the following warning: WARNING: at drivers/base/firmware_class.c:537 _request_firmware+0x3f6/0x420() For rtl8192cu, the problem is fixed by storing the firmware in a global buffer rather than one allocated per device. The usage count is increased when suspending and decreased when resuming. This way, the firmware is retained through a suspend/resume cycle, and does not have to be reread. This patch should fix the bug reported in https://bugzilla.redhat.com/show_bug.cgi?id=771002. Note: This patch also touches rtl8192ce as the "firmware" loaded message is now printed in the wrong place. Reported-by: Mohammed Arafa <redacted> Reported-by: Dave Jones <redacted> Signed-off-by: Larry Finger <redacted> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Stable <redacted> --- V2 - revised to avoid warning noted by Daniel Halperin. ---