[PATCH] mac80211: preserve EOSP in QoS header
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2011-11-03 08:59:43
From: Johannes Berg <redacted> Janusz reported that the EOSP bit in mac80211 was getting cleared all the time. I had not found this since I tested uAPSD with a device that always set the bit itself. Preserve the bit when building the QoS header. Reported-by: Janusz Dziedzic <redacted> Tested-by: Janusz Dziedzic <redacted> Signed-off-by: Johannes Berg <redacted> --- This might conflict slightly with Thomas's patch that adds the NOACK bit for multicast frames. net/mac80211/wme.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
--- a/net/mac80211/wme.c 2011-11-02 11:05:29.000000000 +0100
+++ b/net/mac80211/wme.c 2011-11-03 09:14:30.000000000 +0100@@ -143,10 +143,13 @@ void ieee80211_set_qos_hdr(struct ieee80 /* Fill in the QoS header if there is one. */ if (ieee80211_is_data_qos(hdr->frame_control)) { u8 *p = ieee80211_get_qos_ctl(hdr); - u8 ack_policy = 0, tid; + u8 ack_policy, tid; tid = skb->priority & IEEE80211_QOS_CTL_TAG1D_MASK; + /* preserve EOSP bit */ + ack_policy = *p & IEEE80211_QOS_CTL_EOSP; + if (unlikely(sdata->local->wifi_wme_noack_test)) ack_policy |= IEEE80211_QOS_CTL_ACK_POLICY_NOACK; /* qos header is 2 bytes */