DORMANTno replies

[patch] prism54: potential memory corruption in prism54_get_essid()

From: Dan Carpenter <hidden>
Date: 2011-11-21 14:47:13
Also in: kernel-janitors
Subsystem: networking drivers (wireless), the rest · Maintainers: Johannes Berg, Linus Torvalds

"dwrq->length" is the capped version of "essid->length".

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/wireless/prism54/isl_ioctl.c b/drivers/net/wireless/prism54/isl_ioctl.c
index d97a2ca..bc2ba80 100644
--- a/drivers/net/wireless/prism54/isl_ioctl.c
+++ b/drivers/net/wireless/prism54/isl_ioctl.c
@@ -778,7 +778,7 @@ prism54_get_essid(struct net_device *ndev, struct iw_request_info *info,
 		dwrq->flags = 0;
 		dwrq->length = 0;
 	}
-	essid->octets[essid->length] = '\0';
+	essid->octets[dwrq->length] = '\0';
 	memcpy(extra, essid->octets, dwrq->length);
 	kfree(essid);
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help