[PATCH] b43: Fix smatch warning
From: Larry Finger <hidden>
Date: 2011-08-27 18:26:18
Subsystem:
networking drivers (wireless), the rest · Maintainers:
Johannes Berg, Linus Torvalds
CHECK drivers/net/wireless/b43/main.c drivers/net/wireless/b43/main.c +4115 b43_wireless_core_stop(7) warn: variable dereferenced before check 'dev' Signed-off-by: Larry Finger <redacted> --- John, This is next material. Larry --- drivers/net/wireless/b43/main.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 0628901..2680684 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c@@ -4131,13 +4131,14 @@ out_unlock: * because the core might be gone away while we unlocked the mutex. */ static struct b43_wldev * b43_wireless_core_stop(struct b43_wldev *dev) { - struct b43_wl *wl = dev->wl; + struct b43_wl *wl; struct b43_wldev *orig_dev; u32 mask; redo: if (!dev || b43_status(dev) < B43_STAT_STARTED) return dev; + wl = dev->wl; /* Cancel work. Unlock to avoid deadlocks. */ mutex_unlock(&wl->mutex);
--
1.7.3.4