[PATCH] x86: fix mrst sparse complaints

Subsystems: the rest, x86 architecture (32-bit and 64-bit)

STALE5606d

2 messages, 2 authors, 2011-05-06 · open the first message on its own page

[PATCH] x86: fix mrst sparse complaints

From: Luis R. Rodriguez <hidden>
Date: 2011-05-06 22:00:21

This fixes these few sparse complaints:

  CHECK   arch/x86/platform/mrst/mrst.c
arch/x86/platform/mrst/mrst.c:197:13: warning: symbol 'mrst_time_init' was not declared. Should it be static?
arch/x86/platform/mrst/mrst.c:219:16: warning: symbol 'mrst_arch_setup' was not declared. Should it be static?
  CC      arch/x86/platform/mrst/mrst.o

Cc: Roman Gezikov <redacted>
Cc: Joonas Viskari <redacted>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <redacted>
Cc: Allen Kao <redacted>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: x86@kernel.org
Signed-off-by: Luis R. Rodriguez <redacted>
---
 arch/x86/platform/mrst/mrst.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 275dbc1..7000e74 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -194,7 +194,7 @@ static unsigned long __init mrst_calibrate_tsc(void)
 	return 0;
 }
 
-void __init mrst_time_init(void)
+static void __init mrst_time_init(void)
 {
 	sfi_table_parse(SFI_SIG_MTMR, NULL, NULL, sfi_parse_mtmr);
 	switch (mrst_timer_options) {
@@ -216,7 +216,7 @@ void __init mrst_time_init(void)
 	apbt_time_init();
 }
 
-void __cpuinit mrst_arch_setup(void)
+static void __cpuinit mrst_arch_setup(void)
 {
 	if (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x27)
 		__mrst_cpu_chip = MRST_CPU_CHIP_PENWELL;
-- 
1.7.4.15.g7811d

Re: [PATCH] x86: fix mrst sparse complaints

From: Alan Cox <hidden>
Date: 2011-05-06 22:30:16

On Fri, 6 May 2011 15:00:09 -0700
"Luis R. Rodriguez" [off-list ref] wrote:
This fixes these few sparse complaints:

  CHECK   arch/x86/platform/mrst/mrst.c
arch/x86/platform/mrst/mrst.c:197:13: warning: symbol 'mrst_time_init' was not declared. Should it be static?
arch/x86/platform/mrst/mrst.c:219:16: warning: symbol 'mrst_arch_setup' was not declared. Should it be static?
  CC      arch/x86/platform/mrst/mrst.o
Please Cc me on Moorestown/Medfield tree stuff. Looks sane enough.

Alan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help