[PATCH] b43: Fix a typo in the sync_stx routine

Subsystems: networking drivers (wireless), the rest

STALE6203d

2 messages, 2 authors, 2009-08-10 · open the first message on its own page

[PATCH] b43: Fix a typo in the sync_stx routine

From: Gábor Stefanik <hidden>
Date: 2009-08-10 22:54:28 

I completely missed the "one's complement" instruction from the specs.

Signed-off-by: Gábor Stefanik <redacted>
---
 drivers/net/wireless/b43/phy_lp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 46fe476..34ad738 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -578,7 +578,7 @@ static void lpphy_sync_stx(struct b43_wldev *dev)
 		tmp >>= e->rf_shift;
 		tmp <<= e->phy_shift;
 		b43_phy_maskset(dev, B43_PHY_OFDM(0xF2 + e->phy_offset),
-				e->mask << e->phy_shift, tmp);
+				~(e->mask << e->phy_shift), tmp);
 	}
 }
 
-- 
1.6.2.4

Re: [PATCH] b43: Fix a typo in the sync_stx routine

From: Larry Finger <hidden>
Date: 2009-08-10 23:14:32 

Gábor Stefanik wrote:
quoted hunk
I completely missed the "one's complement" instruction from the specs.

Signed-off-by: Gábor Stefanik <redacted>
---
drivers/net/wireless/b43/phy_lp.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/b43/phy_lp.c
b/drivers/net/wireless/b43/phy_lp.c
index 46fe476..34ad738 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -578,7 +578,7 @@ static void lpphy_sync_stx(struct b43_wldev *dev)
        tmp >>= e->rf_shift;
        tmp <<= e->phy_shift;
        b43_phy_maskset(dev, B43_PHY_OFDM(0xF2 + e->phy_offset),
-                e->mask << e->phy_shift, tmp);
+                ~(e->mask << e->phy_shift), tmp);
    }
}
I should have caught that one.

When debugging gets started, it might be useful to add a statement

      WARN_ON(mask & set);

at the start of b43_radio_maskset() and b43_phy_maskset(). That way
these kind of mistakes will be caught early.

Larry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help