DORMANTno replies

[PATCH] When the "hardware" switch is disabled, don't actually allow changing the softblock status.

From: Mario Limonciello <hidden>
Date: 2009-08-19 23:34:27
Also in: linux-acpi, lkml
Subsystem: the rest, x86 platform drivers · Maintainers: Linus Torvalds, Hans de Goede, Ilpo Järvinen

The "hardware" switch is tied directly to a BIOS interface that will connect and 
disconnect the hardware from the bus.

If you use the software interface to request the BIOS to make these changes, the HW
switch will be in an inconsistent state and LEDs may not reflect the state of the HW.

Signed-off-by: Mario Limonciello <redacted>
---
 drivers/platform/x86/dell-laptop.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 90a3d7c..2469ad5 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -180,6 +180,10 @@ static int dell_rfkill_set(int radio, enum rfkill_state state)
 	int disable = (state == RFKILL_STATE_UNBLOCKED) ? 0 : 1;
 
 	memset(&buffer, 0, sizeof(struct calling_interface_buffer));
+	dell_send_request(&buffer, 17, 11);
+	if (!(buffer.output[1] & BIT(16)))
+		return -EINVAL;
+
 	buffer.input[0] = (1 | (radio<<8) | (disable << 16));
 	dell_send_request(&buffer, 17, 11);
 
-- 
1.6.3.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help