DORMANTno replies

[PATCH] sony: fix rfkill code

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2009-06-07 19:57:12

During the rfkill conversion I added code to call
sony_nc_rfkill_set with the wrong argument, causing
a segfault Reinette reported. The compiler could not
catch that because the argument is, and needs to be,
void *.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Reported-by: Reinette Chatre <reinette.chatre@intel.com>
---
 drivers/platform/x86/sony-laptop.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
--- wireless-testing.orig/drivers/platform/x86/sony-laptop.c	2009-06-07 21:26:30.000000000 +0200
+++ wireless-testing/drivers/platform/x86/sony-laptop.c	2009-06-07 21:49:53.000000000 +0200
@@ -1135,8 +1135,7 @@ static void sony_nc_rfkill_update()
 
 		if (hwblock) {
 			if (rfkill_set_hw_state(sony_rfkill_devices[i], true))
-				sony_nc_rfkill_set(sony_rfkill_devices[i],
-						   true);
+				sony_nc_rfkill_set((void *)i, true);
 			continue;
 		}
 

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help