[PATCH] mac80211: Reorder debugfs calls during netdev deinit

DORMANTno replies

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2008-09-09 14:33:27

From: Jouni Malinen <redacted>

ieee80211_free_keys() must be called before
ieee80211_debugfs_remove_netdev() in order to make sure that the
possible default_key symlink is removed before attempting to
remove the netdev debugfs directory.

Signed-off-by: Jouni Malinen <redacted>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
I've also seen the dangling netdev directories now, even without
802.11w.

 net/mac80211/iface.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
--- everything.orig/net/mac80211/iface.c	2008-09-09 15:09:55.000000000 +0200
+++ everything/net/mac80211/iface.c	2008-09-09 16:29:00.000000000 +0200
@@ -31,11 +31,11 @@ static void ieee80211_teardown_sdata(str
 	int flushed;
 	int i;
 
-	ieee80211_debugfs_remove_netdev(sdata);
-
 	/* free extra data */
 	ieee80211_free_keys(sdata);
 
+	ieee80211_debugfs_remove_netdev(sdata);
+
 	for (i = 0; i < IEEE80211_FRAGMENT_MAX; i++)
 		__skb_queue_purge(&sdata->fragments[i].skb_list);
 	sdata->fragment_next = 0;

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help