[PATCH] mac80211: allow interface settings changes only when down

DORMANTno replies

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2008-09-16 18:23:44

We currently allow monitor flags changes and mesh ID changes when
the interface is up, which can lead to trouble. Change it to only
allow when down.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/cfg.c |    3 +++
 1 file changed, 3 insertions(+)
--- everything.orig/net/mac80211/cfg.c	2008-09-16 20:19:48.000000000 +0200
+++ everything/net/mac80211/cfg.c	2008-09-16 20:20:37.000000000 +0200
@@ -102,6 +102,9 @@ static int ieee80211_change_iface(struct
 	if (ret)
 		return ret;
 
+	if (netif_running(sdata->dev))
+		return -EBUSY;
+
 	if (ieee80211_vif_is_mesh(&sdata->vif) && params->mesh_id_len)
 		ieee80211_sdata_set_mesh_id(sdata,
 					    params->mesh_id_len,

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help