Re: [PATCH 60] drivers/net/wireless/prism54/oid_mgt.c: kmalloc + memset conversion to kzalloc
From: Luis R. Rodriguez <hidden>
Date: 2007-08-01 01:13:06
Also in:
kernel-janitors, lkml
On 7/31/07, Mariusz Kozlowski [off-list ref] wrote:
Signed-off-by: Mariusz Kozlowski <redacted>
Acked-by: Luis R. Rodriguez <redacted>
quoted hunk ↗ jump to hunk
drivers/net/wireless/prism54/oid_mgt.c | 25377 -> 25297 (-80 bytes) drivers/net/wireless/prism54/oid_mgt.o | 128460 -> 128284 (-176 bytes) drivers/net/wireless/prism54/oid_mgt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)--- linux-2.6.23-rc1-mm1-a/drivers/net/wireless/prism54/oid_mgt.c 2007-07-26 13:07:43.000000000 +0200 +++ linux-2.6.23-rc1-mm1-b/drivers/net/wireless/prism54/oid_mgt.c 2007-07-30 00:27:44.000000000 +0200@@ -244,13 +244,11 @@ mgt_init(islpci_private *priv) /* Alloc the cache */ for (i = 0; i < OID_NUM_LAST; i++) { if (isl_oid[i].flags & OID_FLAG_CACHED) { - priv->mib[i] = kmalloc(isl_oid[i].size * + priv->mib[i] = kzalloc(isl_oid[i].size * (isl_oid[i].range + 1), GFP_KERNEL); if (!priv->mib[i]) return -ENOMEM; - memset(priv->mib[i], 0, - isl_oid[i].size * (isl_oid[i].range + 1)); } else priv->mib[i] = NULL; }