Reviews by heikki.krogerus@linux.intel.com
· linux-usb
All review-attestation trailers
(Reviewed-by / Acked-by /
Tested-by / Reported-by /
Suggested-by / Co-developed-by /
Reported-and-tested-by)
by this address on the linux-usb archive.
100 attestations · capped at 100 most-recent. (21 Acked-by, 78 Reviewed-by, 1 Suggested-by)
-
DORMANTno replies
REVIEWED: 6 (6M) [PATCH v5 2/2] usb: typec: tcpm: Add support for Battery Status response message
2026-07-14 · Acked-by -
DORMANTno replies
REVIEWED: 8 (8M) [PATCH v2] usb: typec: qcom-pmic-typec: avoid uninit values in dev_dbg() error paths
2026-07-14 · Reviewed-by -
HOTtoday
REVIEWED: 5 (5M) Re: [PATCH v1] usb: typec: tcpm: qcom: initialize currsrc explicitly
2026-07-14 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v3 3/3] usb: typec: tipd: add TPS66993 support
2026-07-14 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v4] usb: typec: tcpm: implement retry mechanism for Discover Identity VDMs
2026-07-14 · Reviewed-by -
HOTtoday
REVIEWED: 5 (5M) [PATCH v3 2/3] usb: typec: tipd: add read_power_status callback to tipd_data
2026-07-14 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v7 1/3] usb: typec: ucsi: Detect and skip duplicate altmodes from buggy firmware
2026-07-13 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: ucsi: Use %pe to print error pointers
2026-07-13 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: ucsi: Fix race condition and ordering in port unregistration
2026-07-13 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: mux: tusb1046: add missing MODULE_DEVICE_TABLE()
2026-07-13 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v2] usb: typec: tcpci_rt1711h: unregister TCPCI port with devres
2026-07-13 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: core: port: Deattach Type-C connector on component unbind
2026-07-13 · Reviewed-by -
DORMANTno replies
REVIEWED: 6 (6M) [PATCH v3] usb: typec: ucsi: gaokun: unwind notifier on UCSI register failure
2026-07-09 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) [PATCH v4] usb: typec: ucsi: Move long delayed work on system_dfl_long_wq
2026-07-06 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: ucsi: cancel pending work on system suspend
2026-07-03 · Reviewed-by -
COOLING6d
REVIEWED: 5 (5M) Re: [PATCH v2 2/3] usb: typec: tipd: add read_power_status callback to tipd_data
2026-07-03 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: anx7411: use devm_pm_runtime_enable()
2026-07-03 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v4 2/2] usb: typec: tcpm: Add support for Battery Status response message
2026-07-03 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: qcom-pmic-typec: avoid uninit values in dev_dbg() error paths
2026-07-03 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) [PATCH v1] usb: typec: ucsi: Fix debugfs response truncation beyond 16 bytes
2026-06-30 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v1] usb: typec: tcpm: Defensively bound altmode array accesses
2026-06-30 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v3 1/3] usb: typec: Add helper to check cable altmode support
2026-06-30 · Reviewed-by -
COOLING14d
REVIEWED: 9 (9M) [PATCH v3 3/3] usb: typec: displayport: Check cable altmode support
2026-06-26 · Reviewed-by -
COOLING14d
REVIEWED: 9 (9M) [PATCH v3 2/3] usb: typec: thunderbolt: Check cable altmode support
2026-06-26 · Reviewed-by -
COOLING14d
[PATCH v3 1/3] usb: typec: Add helper to check cable altmode support
2026-06-26 · Suggested-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v1] usb: typec: tcpm: Validate SVID index in svdm_consume_modes()
2026-06-23 · Acked-by -
COOLING6d
REVIEWED: 5 (5M) Re: [PATCH v2] usb: typec: ucsi: gaokun: unwind notifier on UCSI register failure
2026-06-23 · Reviewed-by -
DORMANTno replies
REVIEWED: 8 (8M) [PATCH v3] usb: typec: displayport: Reject DP Alt Mode VDO with no pin assignment for its capability
2026-06-23 · Reviewed-by -
COLD20d
REVIEWED: 9 (9M) [PATCH v2 3/3] usb: typec: displayport: Check cable altmode support
2026-06-22 · Reviewed-by -
COLD20d
REVIEWED: 9 (9M) [PATCH v2 2/3] usb: typec: thunderbolt: Check cable altmode support
2026-06-22 · Reviewed-by -
COLD22d
REVIEWED: 8 (8M) [PATCH v2] usb: typec: displayport: Reject DP Alt Mode VDO with no pin assignment for its capability
2026-06-19 · Reviewed-by -
DORMANTno replies
REVIEWED: 11 (11M) [PATCH v2] usb: typec: ucsi: Pass full DP config payload in SET_NEW_CAM for DP alt mode
2026-06-19 · Reviewed-by -
COLD25d
REVIEWED: 11 (11M) [PATCH v1] usb: typec: ucsi: Pass full DP config payload in SET_NEW_CAM for DP alt mode
2026-06-19 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v1 3/3] usb: typec: displayport: Check cable altmode support
2026-06-18 · Reviewed-by -
COLD26d
REVIEWED: 5 (5M) Re: [PATCH v1 2/3] usb: typec: thunderbolt: Check cable altmode support
2026-06-18 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: ucsi: ccg: Fix use-after-free of ucsi on remove
2026-06-18 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) [PATCH v3 3/3] usb: typec: tipd: name TPS_REG_POWER_STATUS field masks
2026-06-18 · Reviewed-by -
COLD26d
REVIEWED: 5 (5M) [PATCH v3 1/3] usb: typec: tipd: add error message for vendor ID read failure
2026-06-18 · Reviewed-by -
COLD26d
REVIEWED: 5 (5M) [PATCH v3 2/3] usb: typec: tipd: demote missing IRQ message to debug
2026-06-18 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: ucsi: huawei_gaokun: support mode switching
2026-06-12 · Acked-by -
COLD32d
REVIEWED: 6 (6M) [PATCH v4 8/8] usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events
2026-06-07 · Acked-by -
COLD32d
REVIEWED: 5 (5M) [PATCH v4 1/8] drm/connector: report out-of-band IRQ_HPD events
2026-06-07 · Acked-by -
COLD32d
REVIEWED: 5 (5M) Re: [PATCH v3 2/2] usb: typec: tcpm: Add support for Battery Status response message
2026-06-05 · Acked-by -
COOLING10d
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: tcpm: Fix VDM type for Enter Mode commands
2026-06-05 · Reviewed-by -
COLD36d
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: ps883x: Fix DP+USB3 configuration
2026-06-05 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: ucsi: Invert DisplayPort role assignment
2026-06-05 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH RESEND v3 1/6] drm/connector: report IRQ_HPD events to drm_connector_oob_hotplug_event()
2026-06-05 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] Revert "usb: typec: mux: avoid duplicated mux switches"
2026-06-01 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v2 2/3] usb: typec: tipd: demote missing IRQ message to debug
2026-06-01 · Reviewed-by -
COLD43d
REVIEWED: 5 (5M) Re: [PATCH v2 1/3] usb: typec: tipd: add error message for vendor ID read failure
2026-06-01 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) [PATCH v3] usb: typec: ucsi: Move long delayed work on system_dfl_long_wq
2026-05-25 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) [PATCH v8 3/3] usb: typec: ucsi: Add support for SET_PDOS command
2026-05-19 · Reviewed-by -
COLD56d
REVIEWED: 5 (5M) [PATCH v8 2/3] usb: typec: ucsi: Enable debugfs for message_out data structure
2026-05-19 · Reviewed-by -
COLD56d
REVIEWED: 5 (5M) [PATCH v8 1/3] usb: typec: ucsi: Add support for message_out data structure
2026-05-19 · Reviewed-by -
COLD43d
REVIEWED: 5 (5M) [PATCH v2 3/3] usb: typec: tipd: name TPS_REG_POWER_STATUS field masks
2026-05-19 · Reviewed-by -
COLD54d
REVIEWED: 5 (5M) Re: [PATCH 1/2] usb: typec: ucsi: Check if power role change actually happened before handling
2026-05-19 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH 2/6] usb: typec: tcpm: qcom: prefer VBUS supply from the connector node
2026-05-19 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH 2/2] USB: typec: qcom-pmic-typec: Drop redundant header includes
2026-05-19 · Reviewed-by -
COLD53d
REVIEWED: 5 (5M) Re: [RFC PATCH v2] usb: typec: ucsi: Move long delayed work on system_dfl_long_wq
2026-05-19 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: ucsi: split connector lock classes
2026-05-18 · Reviewed-by -
COLD56d
REVIEWED: 5 (5M) Re: [PATCH 8/8] usb: typec: ucsi: validate connector number in ucsi_connector_change()
2026-05-18 · Reviewed-by -
COLD56d
REVIEWED: 5 (5M) Re: [PATCH 7/8] usb: typec: ucsi: displayport: NAK DP_CMD_CONFIGURE without a payload VDO
2026-05-18 · Reviewed-by -
COLD56d
REVIEWED: 5 (5M) Re: [PATCH 2/8] usb: typec: altmodes/displayport: validate count before reading Status Update VDO
2026-05-18 · Reviewed-by -
COLD56d
REVIEWED: 5 (5M) Re: [PATCH 1/8] usb: typec: wcove: don't write past struct pd_message in wcove_read_rx_buffer()
2026-05-18 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: ucsi: ccg: reject firmware images without a ':' record header
2026-05-18 · Reviewed-by -
COLD56d
REVIEWED: 5 (5M) Re: [PATCH 3/3] usb: typec: tipd: name TPS_REG_POWER_STATUS field masks
2026-05-18 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH next] usb: typec: tipd: Fix error code in tps6598x_probe()
2026-05-18 · Reviewed-by -
COLD39d
REVIEWED: 6 (6M) [PATCH RESEND v3 6/6] usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events
2026-05-13 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: intel_pmc_mux: Zero initialize num_ports in pmc_usb_probe()
2026-05-06 · Reviewed-by -
STALE61d
REVIEWED: 5 (5M) [PATCH v4] usb: typec: tcpm: improve handling of DISCOVER_MODES failures
2026-04-29 · Reviewed-by -
STALE76d
REVIEWED: 5 (5M) Re: [PATCH v2] usb: typec: fusb302: Fix resource leak when devm_drm_dp_hpd_bridge_add() fails
2026-04-29 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: intel_pmc_mux: combine kzalloc + kcalloc
2026-04-27 · Reviewed-by -
STALE61d
REVIEWED: 5 (5M) Re: [PATCH v2] usb: typec: tcpm: fix debug accessory mode detection for sink ports
2026-04-27 · Acked-by -
STALE77d
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: mux: ps883x: Power the retimer off when not in use
2026-04-27 · Acked-by -
STALE84d
REVIEWED: 6 (6M) [PATCH v3 6/6] usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events
2026-04-20 · Acked-by -
STALE85d
REVIEWED: 6 (6M) [PATCH v2 6/6] usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events
2026-04-20 · Acked-by -
STALE85d
REVIEWED: 5 (5M) Re: [PATCH 6/6] usb: typec: ucsi: huawei-gaokun: pass down HPD_IRQ events
2026-04-17 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: tcpm: reset internal port states on soft reset AMS
2026-04-15 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: ulpi: fix memory leak on ulpi_register() error paths
2026-04-15 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: ucsi: skip connector validation before init
2026-04-07 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v1 2/2] usb: typec: cros_ec_ucsi: Load driver from OF and ACPI definitions
2026-04-07 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v1] usb: typec: ucsi: Set usb mode on partner change
2026-04-07 · Reviewed-by -
STALE102d
REVIEWED: 5 (5M) Re: [PATCH v1 1/1] usb: typec: tipd: Restore generic TPS6598x contract interrupts
2026-04-02 · Acked-by -
DORMANTno replies
REVIEWED: 5 (5M) [PATCH v7 3/3] usb: typec: ucsi: Add support for SET_PDOS command
2026-04-01 · Reviewed-by -
STALE104d
REVIEWED: 5 (5M) [PATCH v7 2/3] usb: typec: ucsi: Enable debugfs for message_out data structure
2026-04-01 · Reviewed-by -
STALE104d
REVIEWED: 5 (5M) [PATCH v7 1/3] usb: typec: ucsi: Add support for message_out data structure
2026-04-01 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH] usb: ulpi: fix double free in ulpi_register_interface() error path
2026-04-01 · Reviewed-by -
STALE74d
REVIEWED: 8 (8M) [PATCH v10 6/6] usb: typec: tcpm/tcpci_maxim: deprecate WAR for setting charger mode
2026-03-31 · Reviewed-by -
STALE105d
REVIEWED: 8 (8M) [PATCH v9 6/6] usb: typec: tcpm/tcpci_maxim: deprecate WAR for setting charger mode
2026-03-25 · Reviewed-by -
STALE112d
REVIEWED: 5 (5M) Re: [PATCH v2] usb: typec: Remove alt->adev.dev.class assignment
2026-03-24 · Reviewed-by -
STALE109d
REVIEWED: 6 (5M) [PATCH v2] usb: typec: thunderbolt: Set enter_vdo during initialization
2026-03-24 · Reviewed-by -
STALE112d
REVIEWED: 5 (5M) Re: [PATCH] usb: typec: thunderbolt: Set enter_vdo during initialization
2026-03-24 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v4 2/2] usb: typec: tcpci: support setting orientation via GPIO
2026-03-23 · Reviewed-by -
STALE106d
REVIEWED: 5 (5M) [PATCH 3/3] usb: typec: ucsi: Add support for SET_PDOS command
2026-03-18 · Reviewed-by -
STALE106d
REVIEWED: 5 (5M) [PATCH 2/3] usb: typec: ucsi: Enable debugfs for message_out data structure
2026-03-18 · Reviewed-by -
STALE106d
REVIEWED: 5 (5M) [PATCH 1/3] usb: typec: ucsi: Add support for message_out data structure
2026-03-18 · Reviewed-by -
STALE117d
REVIEWED: 5 (5M) [PATCH v4 4/4] usb: typec: tcpci_rt1711h: Drop unnecessary VID/PID/DID checks
2026-03-18 · Reviewed-by -
DORMANTno replies
REVIEWED: 5 (5M) Re: [PATCH v3 4/4] usb: typec: tcpci_rt1711h: Drop unnecessary VID/PID/DID checks
2026-03-18 · Reviewed-by -
STALE103d
REVIEWED: 6 (6M) [PATCH v2 3/3] tcpm: Implement sink support for PD SPR AVS negotiation
2026-03-16 · Acked-by -
STALE111d
REVIEWED: 8 (8M) [PATCH RESEND v8 6/6] usb: typec: tcpm/tcpci_maxim: deprecate WAR for setting charger mode
2026-03-14 · Reviewed-by