[PATCH v2] USB: host: Check for null res pointer
From: Jiasheng Jiang <hidden>
Date: 2021-12-20 08:10:48
Also in:
lkml
Subsystem:
the rest, usb isp116x driver, usb subsystem · Maintainers:
Linus Torvalds, Olav Kongas, Greg Kroah-Hartman
The return value of platform_get_resource() needs to be checked.
To avoid use of error pointer in case that there is no suitable resource.
Fixes: 4808a1c02611 ("[PATCH] USB: Add isp116x-hcd USB host controller driver")
Signed-off-by: Jiasheng Jiang <redacted>
---
Changelog:
v1 -> v2
*Change 1. Correct the commit message.
---
drivers/usb/host/isp116x-hcd.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
index 8835f6bd528e..addd2b43a14c 100644
--- a/drivers/usb/host/isp116x-hcd.c
+++ b/drivers/usb/host/isp116x-hcd.c@@ -1541,9 +1541,15 @@ static int isp116x_remove(struct platform_device *pdev) iounmap(isp116x->data_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); + if (!res) + return -EINVAL; + release_mem_region(res->start, 2); iounmap(isp116x->addr_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; + release_mem_region(res->start, 2); usb_put_hcd(hcd);
--
2.25.1