[PATCH v2] usb: host: ohci-tmio: check return value after calling platform_get_resource()
DORMANTno replies
LANDED: 5 (5M)
From: Yang Yingliang <hidden>
Date: 2021-10-11 13:42:18
Also in:
lkml
Subsystem:
the rest, usb ohci driver, usb subsystem · Maintainers:
Linus Torvalds, Alan Stern, Greg Kroah-Hartman
1 review trailer (1 from subsystem maintainers); landed in mainline as 9eff2b2e59fd on 2021-10-13.
It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang <redacted> Acked-by: Alan Stern <stern@rowland.harvard.edu> --- v2: combine the new checkings with cell checking --- drivers/usb/host/ohci-tmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
index 08ec2ab0d95a..3f3d62dc0674 100644
--- a/drivers/usb/host/ohci-tmio.c
+++ b/drivers/usb/host/ohci-tmio.c@@ -199,7 +199,7 @@ static int ohci_hcd_tmio_drv_probe(struct platform_device *dev) if (usb_disabled()) return -ENODEV; - if (!cell) + if (!cell || !regs || !config || !sram) return -EINVAL; if (irq < 0)
--
2.25.1