[PATCH] Usb: Storage: usb: Fixed coding style issue

Subsystems: the rest, usb mass storage driver, usb subsystem

STALE1807d

2 messages, 2 authors, 2021-08-26 · open the first message on its own page

[PATCH] Usb: Storage: usb: Fixed coding style issue

From: Niklas Lantau <hidden>
Date: 2021-08-21 12:17:59

Fixed coding style issue. Removed not needed braces.

Signed-off-by: Niklas Lantau <redacted>
---
 drivers/usb/storage/usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index 90aa9c12ffac..5f562bac14d0 100644
--- a/drivers/usb/storage/usb.c
+++ b/drivers/usb/storage/usb.c
@@ -926,9 +926,8 @@ static unsigned int usb_stor_sg_tablesize(struct usb_interface *intf)
 {
 	struct usb_device *usb_dev = interface_to_usbdev(intf);
 
-	if (usb_dev->bus->sg_tablesize) {
+	if (usb_dev->bus->sg_tablesize)
 		return usb_dev->bus->sg_tablesize;
-	}
 	return SG_ALL;
 }
 
-- 
2.33.0

Re: [PATCH] Usb: Storage: usb: Fixed coding style issue

From: Greg KH <hidden>
Date: 2021-08-26 11:24:34

On Sat, Aug 21, 2021 at 02:16:30PM +0200, Niklas Lantau wrote:
Fixed coding style issue. Removed not needed braces.
That is not easy to parse.

And it is written either "USB" or "usb", never "Usb".

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help