[PATCH] [v2,1/1] This aims to support Foxconn SDX55

Subsystems: the rest, usb serial subsystem, usb subsystem

STALE1842d

7 messages, 3 authors, 2021-08-12 · open the first message on its own page

[PATCH] [v2,1/1] This aims to support Foxconn SDX55

From: Slark Xiao <hidden>
Date: 2021-08-11 08:56:59

Foxconn SDX55 T77W175 device is working in PCIe mode normally.
You can find it in drivers/bus/mhi/pci_geneirc.c file.
But in some scenario, we need to capture the memory dump once it crashed.
So a diag port driver is needed.

Signed-off-by: Slark Xiao <redacted>
---
 drivers/usb/serial/qcserial.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 83da8236e3c8..d8b58aea3c60 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -111,6 +111,7 @@ static const struct usb_device_id id_table[] = {
 	{USB_DEVICE(0x16d8, 0x8002)},	/* CMDTech Gobi 2000 Modem device (VU922) */
 	{USB_DEVICE(0x05c6, 0x9204)},	/* Gobi 2000 QDL device */
 	{USB_DEVICE(0x05c6, 0x9205)},	/* Gobi 2000 Modem device */
+	{USB_DEVICE(0x05c6, 0x901d)},	/* Foxconn SDX55 QDL */
 
 	/* Gobi 3000 devices */
 	{USB_DEVICE(0x03f0, 0x371d)},	/* HP un2430 Gobi 3000 QDL */
-- 
2.25.1

Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

From: Sergei Shtylyov <hidden>
Date: 2021-08-11 10:58:24

Hello!

On 11.08.2021 11:56, Slark Xiao wrote:
Foxconn SDX55 T77W175 device is working in PCIe mode normally.
You can find it in drivers/bus/mhi/pci_geneirc.c file.
    pci_generic? :-)
But in some scenario, we need to capture the memory dump once it crashed.
So a diag port driver is needed.

Signed-off-by: Slark Xiao <redacted>
[...]

MBR, Sergei

Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-08-11 11:42:25

On Wed, Aug 11, 2021 at 04:56:35PM +0800, Slark Xiao wrote:
quoted hunk
Foxconn SDX55 T77W175 device is working in PCIe mode normally.
You can find it in drivers/bus/mhi/pci_geneirc.c file.
But in some scenario, we need to capture the memory dump once it crashed.
So a diag port driver is needed.

Signed-off-by: Slark Xiao <redacted>
---
 drivers/usb/serial/qcserial.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 83da8236e3c8..d8b58aea3c60 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -111,6 +111,7 @@ static const struct usb_device_id id_table[] = {
 	{USB_DEVICE(0x16d8, 0x8002)},	/* CMDTech Gobi 2000 Modem device (VU922) */
 	{USB_DEVICE(0x05c6, 0x9204)},	/* Gobi 2000 QDL device */
 	{USB_DEVICE(0x05c6, 0x9205)},	/* Gobi 2000 Modem device */
+	{USB_DEVICE(0x05c6, 0x901d)},	/* Foxconn SDX55 QDL */
Why is this not sorted?

And the subject needs some work still...

thanks,

greg k-h

Re:Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

From: Slark Xiao <hidden>
Date: 2021-08-12 01:47:23
















At 2021-08-11 18:58:09, "Sergei Shtylyov" [off-list ref] wrote:
Hello!

On 11.08.2021 11:56, Slark Xiao wrote:
quoted
Foxconn SDX55 T77W175 device is working in PCIe mode normally.
You can find it in drivers/bus/mhi/pci_geneirc.c file.
   pci_generic? :-)
quoted
But in some scenario, we need to capture the memory dump once it crashed.
So a diag port driver is needed.

Signed-off-by: Slark Xiao <redacted>
[...]

MBR, Sergei
Hi Sergei,
   Yes, I didn't mix them up. Our product supports 3 modes: PCIE only, USB only, and PCIE+USB.
   Normally, it would be PCIE mode. When we want to reproduce some crash issue, we will switch it from PCIE mode to PCIE+USB mode.
  In this scenario, the USB port is used for capturing memory dump as our tool is designed based on Qualcomm USB Sahara protocol.

Thanks.

Re:Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

From: Slark Xiao <hidden>
Date: 2021-08-12 01:53:19
















At 2021-08-11 19:42:20, "Greg KH" [off-list ref] wrote:
On Wed, Aug 11, 2021 at 04:56:35PM +0800, Slark Xiao wrote:
quoted
Foxconn SDX55 T77W175 device is working in PCIe mode normally.
You can find it in drivers/bus/mhi/pci_geneirc.c file.
But in some scenario, we need to capture the memory dump once it crashed.
So a diag port driver is needed.

Signed-off-by: Slark Xiao <redacted>
---
 drivers/usb/serial/qcserial.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 83da8236e3c8..d8b58aea3c60 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -111,6 +111,7 @@ static const struct usb_device_id id_table[] = {
 	{USB_DEVICE(0x16d8, 0x8002)},	/* CMDTech Gobi 2000 Modem device (VU922) */
 	{USB_DEVICE(0x05c6, 0x9204)},	/* Gobi 2000 QDL device */
 	{USB_DEVICE(0x05c6, 0x9205)},	/* Gobi 2000 Modem device */
+	{USB_DEVICE(0x05c6, 0x901d)},	/* Foxconn SDX55 QDL */
Why is this not sorted?

And the subject needs some work still...

thanks,

greg k-h
Hi Greg,
  Sorry,  can you show me where should I put it at?
  According to Bjørn comment, I think I need to create a new layout for Foxconn SDX55 device.

Thanks.

Re: Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2021-08-12 06:47:00

On Thu, Aug 12, 2021 at 09:52:56AM +0800, Slark Xiao wrote:
At 2021-08-11 19:42:20, "Greg KH" [off-list ref] wrote:
quoted
On Wed, Aug 11, 2021 at 04:56:35PM +0800, Slark Xiao wrote:
quoted
Foxconn SDX55 T77W175 device is working in PCIe mode normally.
You can find it in drivers/bus/mhi/pci_geneirc.c file.
But in some scenario, we need to capture the memory dump once it crashed.
So a diag port driver is needed.

Signed-off-by: Slark Xiao <redacted>
---
 drivers/usb/serial/qcserial.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 83da8236e3c8..d8b58aea3c60 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -111,6 +111,7 @@ static const struct usb_device_id id_table[] = {
 	{USB_DEVICE(0x16d8, 0x8002)},	/* CMDTech Gobi 2000 Modem device (VU922) */
 	{USB_DEVICE(0x05c6, 0x9204)},	/* Gobi 2000 QDL device */
 	{USB_DEVICE(0x05c6, 0x9205)},	/* Gobi 2000 Modem device */
+	{USB_DEVICE(0x05c6, 0x901d)},	/* Foxconn SDX55 QDL */
Why is this not sorted?

And the subject needs some work still...

thanks,

greg k-h
Hi Greg,
  Sorry,  can you show me where should I put it at?
If it belongs in this list, then it should be in sorted order, which you
did not do here, so that would be a good idea, right?
  According to Bjørn comment, I think I need to create a new layout for Foxconn SDX55 device.
That is up to you and Bjørn to work out :)

thanks,

greg k-h

Re:Re: Re: [PATCH] [v2,1/1] This aims to support Foxconn SDX55

From: Slark Xiao <hidden>
Date: 2021-08-12 11:06:46
















At 2021-08-12 14:46:54, "Greg KH" [off-list ref] wrote:
On Thu, Aug 12, 2021 at 09:52:56AM +0800, Slark Xiao wrote:
quoted
At 2021-08-11 19:42:20, "Greg KH" [off-list ref] wrote:
quoted
On Wed, Aug 11, 2021 at 04:56:35PM +0800, Slark Xiao wrote:
quoted
Foxconn SDX55 T77W175 device is working in PCIe mode normally.
You can find it in drivers/bus/mhi/pci_geneirc.c file.
But in some scenario, we need to capture the memory dump once it crashed.
So a diag port driver is needed.

Signed-off-by: Slark Xiao <redacted>
---
 drivers/usb/serial/qcserial.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c
index 83da8236e3c8..d8b58aea3c60 100644
--- a/drivers/usb/serial/qcserial.c
+++ b/drivers/usb/serial/qcserial.c
@@ -111,6 +111,7 @@ static const struct usb_device_id id_table[] = {
 	{USB_DEVICE(0x16d8, 0x8002)},	/* CMDTech Gobi 2000 Modem device (VU922) */
 	{USB_DEVICE(0x05c6, 0x9204)},	/* Gobi 2000 QDL device */
 	{USB_DEVICE(0x05c6, 0x9205)},	/* Gobi 2000 Modem device */
+	{USB_DEVICE(0x05c6, 0x901d)},	/* Foxconn SDX55 QDL */
Why is this not sorted?

And the subject needs some work still...

thanks,

greg k-h
Hi Greg,
  Sorry,  can you show me where should I put it at?
If it belongs in this list, then it should be in sorted order, which you
did not do here, so that would be a good idea, right?
quoted
  According to Bjørn comment, I think I need to create a new layout for Foxconn SDX55 device.
That is up to you and Bjørn to work out :)

thanks,

greg k-h
Hi Greg, Bjørn,
   How about move this change to /drivers/usb/serial/option.c ? I just test it and everything is ok for my device.
   And then we can ignore the layout issue.

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help