[PATCH] nt: usb: USB_RTL8153_ECM should not default to y

Subsystems: networking drivers, the rest, usb networking drivers

STALE2024d LANDED

Landed in mainline as 7da17624e794 on 2021-01-14.

3 messages, 3 authors, 2021-01-14 · open the first message on its own page

[PATCH] nt: usb: USB_RTL8153_ECM should not default to y

From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: 2021-01-13 14:44:13

In general, device drivers should not be enabled by default.

Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/usb/Kconfig | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 1e37190287808973..fbbe786436319013 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -631,7 +631,6 @@ config USB_NET_AQC111
 config USB_RTL8153_ECM
 	tristate "RTL8153 ECM support"
 	depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n)
-	default y
 	help
 	  This option supports ECM mode for RTL8153 ethernet adapter, when
 	  CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not
-- 
2.25.1

Re: [PATCH] nt: usb: USB_RTL8153_ECM should not default to y

From: Greg KH <hidden>
Date: 2021-01-13 16:00:00

On Wed, Jan 13, 2021 at 03:43:09PM +0100, Geert Uytterhoeven wrote:
quoted hunk
In general, device drivers should not be enabled by default.

Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/usb/Kconfig | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 1e37190287808973..fbbe786436319013 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -631,7 +631,6 @@ config USB_NET_AQC111
 config USB_RTL8153_ECM
 	tristate "RTL8153 ECM support"
 	depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n)
-	default y
 	help
 	  This option supports ECM mode for RTL8153 ethernet adapter, when
 	  CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH] nt: usb: USB_RTL8153_ECM should not default to y

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-01-14 19:01:09

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 13 Jan 2021 15:43:09 +0100 you wrote:
In general, device drivers should not be enabled by default.

Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/usb/Kconfig | 1 -
 1 file changed, 1 deletion(-)
Here is the summary with links:
  - nt: usb: USB_RTL8153_ECM should not default to y
    https://git.kernel.org/netdev/net/c/7da17624e794

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help