[PATCH] usb: gadget: function: printer: Fix a memory leak for interface descriptor

Subsystems: the rest, usb subsystem

STALE2061d

2 messages, 2 authors, 2020-12-09 · open the first message on its own page

[PATCH] usb: gadget: function: printer: Fix a memory leak for interface descriptor

From: <hidden>
Date: 2020-12-09 03:01:33

From: Zqiang <redacted>

When printer driver be load, the printer_func_bind function be called, in
this function, the interface descriptor be allocated memory, if after that,
the error occurred, the interface descriptor memory need to be free.

Signed-off-by: Zqiang <redacted>
---
 drivers/usb/gadget/function/f_printer.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index 64a4112068fc..2f1eb2e81d30 100644
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -1162,6 +1162,7 @@ static int printer_func_bind(struct usb_configuration *c,
 		printer_req_free(dev->in_ep, req);
 	}
 
+	usb_free_all_descriptors(f);
 	return ret;
 
 }
-- 
2.17.1

Re: [PATCH] usb: gadget: function: printer: Fix a memory leak for interface descriptor

From: Peter Chen <hidden>
Date: 2020-12-09 13:46:34

On 20-12-09 11:00:18, qiang.zhang@windriver.com wrote:
From: Zqiang <redacted>

When printer driver be load, the printer_func_bind function be called, in
		      is loaded				      is called
this function, the interface descriptor be allocated memory, if after that,
				descriptors memory region are allocated
the error occurred, the interface descriptor memory need to be free.
		occurs,			

Except Typo, otherwise:
Reviewed-by: Peter Chen <redacted>

Besides, it is bug-fix, you could add fixes tag, and cc stable@vger.kernel.org.

Peter
quoted hunk
Signed-off-by: Zqiang <redacted>
---
 drivers/usb/gadget/function/f_printer.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c
index 64a4112068fc..2f1eb2e81d30 100644
--- a/drivers/usb/gadget/function/f_printer.c
+++ b/drivers/usb/gadget/function/f_printer.c
@@ -1162,6 +1162,7 @@ static int printer_func_bind(struct usb_configuration *c,
 		printer_req_free(dev->in_ep, req);
 	}
 
+	usb_free_all_descriptors(f);
 	return ret;
 
 }
-- 
2.17.1
-- 

Thanks,
Peter Chen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help