[2/2] usb: typec: ucsi: add support for Cypress CCGx
From: kbuild test robot <hidden>
Date: 2018-09-01 18:31:03
Hi Ajay, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.19-rc1 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ajay-Gupta/i2c-buses-add-i2c-bus-driver-for-NVIDIA-GPU/20180827-092936 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/usb//typec/ucsi/ucsi_i2c_ccg.c: In function 'ucsi_i2c_ccg_resume':
quoted
drivers/usb//typec/ucsi/ucsi_i2c_ccg.c:559:8: error: implicit declaration of function 'ucsi_run_command'; did you mean 'ucsi_i2c_ccg_cmd'? [-Werror=implicit-function-declaration]
ret = ucsi_run_command(ui->ucsi, &c, NULL, 0);
^~~~~~~~~~~~~~~~
ucsi_i2c_ccg_cmd
cc1: some warnings being treated as errors
vim +559 drivers/usb//typec/ucsi/ucsi_i2c_ccg.c
544
545 static int ucsi_i2c_ccg_resume(struct device *dev)
546 {
547 struct i2c_client *client = to_i2c_client(dev);
548 struct ucsi_i2c_ccg *ui = i2c_get_clientdata(client);
549 struct ucsi_control c;
550 int ret;
551
552 if (device_may_wakeup(dev) && ui->wake_enabled) {
553 disable_irq_wake(ui->irq);
554 ui->wake_enabled = false;
555 }
556
557 /* restore UCSI notification enable mask */
558 UCSI_CMD_SET_NTFY_ENABLE(c, UCSI_ENABLE_NTFY_ALL);
> 559 ret = ucsi_run_command(ui->ucsi, &c, NULL, 0);
560 if (ret) {
561 dev_err(ui->dev, "%s: failed to set notification enable - %d\n",
562 __func__, ret);
563 }
564
565 return 0;
566 }
567
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation