# Re: \[PATCH 07/13\] mm/madvise: convert madvise\_vma\_behavior() to use vma\_flags\_t

- From: Lorenzo Stoakes (ARM) \<ljs@kernel.org\>
- Date: 2026-11-09 17:01:33 
- List: linux-trace-kernel
- Page: https://ratatoskr.run/linux-trace-kernel/2026/11/17898807
- Thread: https://ratatoskr.run/linux-mm/2026/11/17874173/t.md

```text
On Mon, Nov 09, 2026 at 03:10:12PM +0100, David Hildenbrand (Arm) wrote:
> > --- a/mm/ksm.c
> > +++ b/mm/ksm.c
> > @@ -779,7 +779,8 @@ static struct vm_area_struct *find_mergeable_vma(struct mm_struct *mm,
> >  	if (ksm_test_exit(mm))
> >  		return NULL;
> >  	vma = vma_lookup(mm, addr);
> > -	if (!vma || !vma_test(vma, VMA_MERGEABLE_BIT) || !vma_has_anon_rmap(vma))
> > +	if (!vma || !vma_test(vma, VMA_MERGEABLE_BIT) ||
> > +	    !vma_has_anon_rmap(vma))
>
> This change should be dropped form this patch IIUC.
>
> It would have to go into the previous one (that I applied) but it's not actually
> required.
>
> Unless I am missing something :)

Yup I'm not bothered by whitespace-only changes :P Feel free to drop this bit!

--
Cheers, Lorenzo
```