# Re: \[PATCH v2 3/6\] tracing: Use copy\_from\_user\_nul() instead of copy\_from\_user()

- From: Steven Rostedt \<rostedt@goodmis.org\>
- Date: 2026-01-12 15:43:12 
- List: linux-trace-kernel
- Page: https://ratatoskr.run/linux-trace-kernel/2026/01/3363893
- Thread: https://ratatoskr.run/linux-trace-kernel/2026/01/3362849/t.md

```text
On Mon, 12 Jan 2026 15:30:36 +0800
Fushuai Wang [ref] wrote:

> From: Fushuai Wang <redacted>
> 
> Use copy_from_user_nul() instead of copy_from_user() to simplify
> the code.
> 
> No functional change.
> 
> Signed-off-by: Fushuai Wang <redacted>

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

> ---
>  kernel/trace/trace.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index baec63134ab6..b6ffd006fcf9 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -11266,10 +11266,9 @@ ssize_t trace_parse_run_command(struct file *file, const char __user *buffer,
>  		if (size >= WRITE_BUFSIZE)
>  			size = WRITE_BUFSIZE - 1;
>  
> -		if (copy_from_user(kbuf, buffer + done, size))
> +		if (copy_from_user_nul(kbuf, buffer + done, size))
>  			return -EFAULT;
>  
> -		kbuf[size] = '\0';
>  		buf = kbuf;
>  		do {
>  			tmp = strchr(buf, '\n');

```
