# \[PATCH v2 4/6\] userns: Use copy\_from\_user\_nul() instead of copy\_from\_user()

- From: Fushuai Wang \<hidden\>
- Date: 2026-01-12 07:32:10 
- List: linux-trace-kernel
- Page: https://ratatoskr.run/linux-trace-kernel/2026/01/3362853
- Thread: https://ratatoskr.run/linux-trace-kernel/2026/01/3362849/t.md

```text
From: Fushuai Wang <redacted>

Use copy_from_user_nul() instead of copy_from_user() to simplify
the code.

No functional change.

Signed-off-by: Fushuai Wang <redacted>
---
 kernel/user_namespace.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
index 03cb63883d04..881a05a3502c 100644
--- a/kernel/user_namespace.c
+++ b/kernel/user_namespace.c
@@ -1239,9 +1239,8 @@ ssize_t proc_setgroups_write(struct file *file, const char __user *buf,
 
 	/* What was written? */
 	ret = -EFAULT;
-	if (copy_from_user(kbuf, buf, count))
+	if (copy_from_user_nul(kbuf, buf, count))
 		goto out;
-	kbuf[count] = '\0';
 	pos = kbuf;
 
 	/* What is being requested? */
-- 
2.36.1

```
