# Re: \[PATCH 1/3\] mm: change vm\_get\_page\_prot() to accept vm\_flags\_t argument

- From: Oscar Salvador \<osalvador@suse.de\>
- Date: 2025-06-19 12:12:56 
- List: linux-trace-kernel
- Page: https://ratatoskr.run/linux-trace-kernel/2025/06/315176
- Thread: https://ratatoskr.run/linuxppc-dev/2025/06/315057/t.md

```text
On Wed, Jun 18, 2025 at 08:42:52PM +0100, Lorenzo Stoakes wrote:
> We abstract the type of the VMA flags to vm_flags_t, however in may places
                                                                  many?
> it is simply assumed this is unsigned long, which is simply incorrect.
> 
> At the moment this is simply an incongruity, however in future we plan to
> change this type and therefore this change is a critical requirement for
> doing so.
> 
> Overall, this patch does not introduce any functional change.
> 
> Signed-off-by: Lorenzo Stoakes <redacted>

Reviewed-by: Oscar Salvador <osalvador@suse.de>

Same comments as Vlastimil, you want to push vmflag_to_pte_pkey_bits
further to patch#2 and bring 

arch/powerpc/mm/book3s64/pgtable.c:pgprot_t vm_get_page_prot(unsigned long vm_flags)


-- 
Oscar Salvador
SUSE Labs
```