Re: [PATCH] tracing, AER: Hide PCIe AER event when PCIEAER is not configured
From: Borislav Petkov <bp@alien8.de>
Date: 2025-06-12 16:14:58
Also in:
linux-edac, lkml
From: Borislav Petkov <bp@alien8.de>
Date: 2025-06-12 16:14:58
Also in:
linux-edac, lkml
On Thu, Jun 12, 2025 at 09:49:32AM -0400, Steven Rostedt wrote:
From: Steven Rostedt <rostedt@goodmis.org> The event aer_event is only used when CONFIG_PCIEAER is configured. It should not be created when it is not. When an event is created it creates around 5K of text and meta data regardless if the tracepoint is used or not. Instead of wasting this memory, put #ifdef around the event to not create it when it is not used. Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> --- Note, I will be adding code soon that will make unused events cause a warning. include/ras/ras_event.h | 2 ++ 1 file changed, 2 insertions(+)diff --git a/include/ras/ras_event.h b/include/ras/ras_event.h index 14c9f943d53f..c8cd0f00c845 100644 --- a/include/ras/ras_event.h +++ b/include/ras/ras_event.h@@ -252,6 +252,7 @@ TRACE_EVENT(non_standard_event, __print_hex(__get_dynamic_array(buf), __entry->len)) ); +#ifdef CONFIG_PCIEAER /* * PCIe AER Trace event *@@ -337,6 +338,7 @@ TRACE_EVENT(aer_event, __print_array(__entry->tlp_header, PCIE_STD_MAX_TLP_HEADERLOG, 4) : "Not available") ); +#endif /* CONFIG_PCIEAER */ /* * memory-failure recovery action result event--
Acked-by: Borislav Petkov (AMD) <bp@alien8.de>