# Re: \[PATCH v10 1/5\] rust: add static\_branch\_unlikely for static\_key\_false

- From: Sami Tolvanen \<samitolvanen@google.com\>
- Date: 2024-10-11 21:26:28 
- List: linux-trace-kernel
- Page: https://ratatoskr.run/linux-trace-kernel/2024/10/2779791
- Thread: https://ratatoskr.run/linux-trace-kernel/2024/10/2778864/t.md

```text
On Fri, Oct 11, 2024 at 12:48 PM Miguel Ojeda
[ref] wrote:
>
> On Fri, Oct 11, 2024 at 7:52 PM Sami Tolvanen [ref] wrote:
> >
> > It's just one line per helper, but sure, I do see your point.
>
> I guess we will have a lot of helpers added over time, so even if it
> is one line, it may end up being a lot of lines in total. The rules
> should stay constant, which would be better. Having said that, it is
> true the extra complexity of the rules isn't great either.

My only concern is that custom C build rules must be kept in sync with
Makefile.build changes, while EXPORT_SYMBOL lines should be basically
maintenance-free. However, perhaps this isn't really an issue since
most of the complexity is already contained in rule_cc_o_c that we can
conveniently reuse. Anyway, I think this is something we can worry
about later if we actually run into problems. I was mostly interested
in the reasoning behind these changes.

Sami
```