# Re: \[PATCH 1/1\] uprobe: fix comment of uprobe\_apply()

- From: Oleg Nesterov \<oleg@redhat.com\>
- Date: 2024-08-20 14:30:23 
- List: linux-trace-kernel
- Page: https://ratatoskr.run/linux-trace-kernel/2024/08/2714975
- Thread: https://ratatoskr.run/linux-trace-kernel/2024/08/2714921/t.md

```text
On 08/20, Zhen Lei wrote:
>
> Depending on the argument 'add', uprobe_apply() may be registering or
> unregistering a probe.

...

>  /*
> - * uprobe_apply - unregister an already registered probe.
> - * @inode: the file in which the probe has to be removed.
> + * uprobe_apply - register a probe or unregister an already registered probe.

Not really.

See the commit 3c83a9ad0295eb63bd ("uprobes: make uprobe_register() return struct uprobe *")
in tip/perf/core which changed this description

	* uprobe_apply - add or remove the breakpoints according to @uc->filter

still looks confusing, yes...

Oleg.

```
