# \[PATCH 0/2\] function\_graph: ftrace\_graph\_ret\_addr(); there can be only one!

- From: Steven Rostedt \<rostedt@goodmis.org\>
- Date: 2024-06-11 03:17:23 
- List: linux-trace-kernel
- Page: https://ratatoskr.run/linux-trace-kernel/2024/06/2633440
- Thread: https://ratatoskr.run/linux-trace-kernel/2024/06/2633440/t.md

```text

I noticed a slight bug in ftrace_graph_ret_addr() for when
HAVE_FUNCTION_GRAPH_RET_ADDR_PTR was defined and fixed it up.
I then noticed it was buggy when not defined. Looking for an
architecture that did not have it defined, I couldn't find any.
So I removed it.

Steven Rostedt (Google) (2):
      function_graph: Fix up ftrace_graph_ret_addr()
      function_graph: Everyone uses HAVE_FUNCTION_GRAPH_RET_ADDR_PTR, remove it

----
 Documentation/trace/ftrace-design.rst | 12 -------
 arch/arm64/include/asm/ftrace.h       | 11 -------
 arch/csky/include/asm/ftrace.h        |  2 --
 arch/loongarch/include/asm/ftrace.h   |  1 -
 arch/powerpc/include/asm/ftrace.h     |  2 --
 arch/riscv/include/asm/ftrace.h       |  1 -
 arch/s390/include/asm/ftrace.h        |  1 -
 arch/x86/include/asm/ftrace.h         |  2 --
 include/linux/ftrace.h                |  2 --
 kernel/trace/fgraph.c                 | 61 ++++++++++++-----------------------
 10 files changed, 20 insertions(+), 75 deletions(-)
```
