# Re: \[RFC PATCH 02/14\] tracing/filters: Enable filtering a cpumask field by another cpumask

- From: Steven Rostedt \<rostedt@goodmis.org\>
- Date: 2023-07-05 18:54:40 
- List: linux-trace-kernel
- Page: https://ratatoskr.run/linux-trace-kernel/2023/07/2255273
- Thread: https://ratatoskr.run/linux-trace-kernel/2023/07/2255228/t.md

```text
On Wed,  5 Jul 2023 19:12:44 +0100
Valentin Schneider [ref] wrote:

> +		/* Copy the cpulist between { and } */
> +		tmp = kmalloc(i - maskstart + 1, GFP_KERNEL);
> +		strncpy(tmp, str + maskstart, i - maskstart);
> +		tmp[i - maskstart] = '\0';
> +

You can replace the above with:

	tmp = kmalloc((i - maskstart) + 1, GFP_KERNEL);
	strscpy(tmp, str + maskstart, (i - maskstart) + 1);

As strscpy() adds the nul terminating character, not to mention that
strncpy() is deprecated (see Documentation/process/deprecated.rst).

-- Steve
```