# Re: \[PATCH 01/20\] x86: move prepare\_ftrace\_return prototype to header

- From: Steven Rostedt \<rostedt@goodmis.org\>
- Date: 2023-05-16 21:44:35 
- List: linux-trace-kernel
- Page: https://ratatoskr.run/linux-trace-kernel/2023/05/2199944
- Thread: https://ratatoskr.run/linux-trace-kernel/2023/05/2199796/t.md

```text
On Tue, 16 May 2023 21:35:30 +0200
Arnd Bergmann [ref] wrote:

> From: Arnd Bergmann <arnd@arndb.de>
> 
> On 32-bit builds, the prepare_ftrace_return() function only has a global
> definition, but no prototype before it, which causes a warning:
> 
> arch/x86/kernel/ftrace.c:625:6: warning: no previous prototype for ‘prepare_ftrace_return’ [-Wmissing-prototypes]
>   625 | void prepare_ftrace_return(unsigned long ip, unsigned long *parent,
> 
> Move the prototype that is already needed for some configurations into
> a header file where it can be seen unconditionally.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/x86/include/asm/ftrace.h | 3 +++
>  arch/x86/kernel/ftrace.c      | 3 ---
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/include/asm/ftrace.h b/arch/x86/include/asm/ftrace.h
> index 5061ac98ffa1..b8d4a07f9595 100644
> --- a/arch/x86/include/asm/ftrace.h
> +++ b/arch/x86/include/asm/ftrace.h

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve
```