Re: [PATCH] tracing: Fix warning on variable 'struct trace_array'
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Date: 2022-11-11 12:49:22
Also in:
lkml
On Mon, 7 Nov 2022 21:35:56 +0530 Aashish Sharma [off-list ref] wrote:
Move the declaration of 'struct trace_array' out of #ifdef CONFIG_TRACING block, to fix the following warning when CONFIG_TRACING is not set:quoted
quoted
include/linux/trace.h:63:45: warning: 'struct trace_array' declaredinside parameter list will not be visible outside of this definition or declaration
This looks good to me. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Thank you!
quoted hunk
Fixes: 1a77dd1c2bb5 ("scsi: tracing: Fix compile error in trace_array calls when TRACING is disabled") Cc: Arun Easi <redacted> Signed-off-by: Aashish Sharma <redacted> --- include/linux/trace.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/include/linux/trace.h b/include/linux/trace.h index b5e16e438448..80ffda871749 100644 --- a/include/linux/trace.h +++ b/include/linux/trace.h@@ -26,13 +26,13 @@ struct trace_export { int flags; }; +struct trace_array; + #ifdef CONFIG_TRACING int register_ftrace_export(struct trace_export *export); int unregister_ftrace_export(struct trace_export *export); -struct trace_array; - void trace_printk_init_buffers(void); __printf(3, 4) int trace_array_printk(struct trace_array *tr, unsigned long ip,-- 2.38.1.431.g37b22c650d-goog
-- Masami Hiramatsu (Google) [off-list ref]