Re: [PATCH] pwm-backlight: add regulator and GPIO support
From: Sascha Hauer <hidden>
Date: 2012-07-04 20:26:53
Also in:
linux-fbdev, lkml
On Thu, Jul 05, 2012 at 12:14:39AM +0900, Alex Courbot wrote:
On Wed 04 Jul 2012 10:00:56 PM JST, Sascha Hauer wrote:quoted
quoted
That's very bad indeed. I assumed that the kernel would free devm-allocated resources after probe returned -EPROBE_DEFER,It indeed does free devm allocated resources, but neither the gpio nor the pwm are devm allocated.As far as I can tell the gpio is allocated through devm as well:quoted
+ ret = devm_gpio_request_one(&pdev->dev, data->enable_gpio, + GPIOF_OUT_INIT_HIGH, "backlight_enable");
You're right. For the GPIO it's ok the way it is. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |