Thread (3 messages) 3 messages, 2 authors, 2021-09-30

Re: [PATCH] staging: vchiq: Update TODO file

From: Ojaswin Mujoo <hidden>
Date: 2021-09-30 16:49:21
Also in: linux-arm-kernel, lkml

On Tue, Sep 28, 2021 at 09:10:44AM +0200, Greg KH wrote:
On Mon, Sep 27, 2021 at 11:43:23PM +0530, Ojaswin Mujoo wrote:
quoted
Remove completed tasks from TODO and add some relevant details to task
14.

Signed-off-by: Ojaswin Mujoo <redacted>
---
 drivers/staging/vc04_services/interface/TODO | 43 ++++----------------
 1 file changed, 7 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO
index 39810ce017cd..5a6b3fc2663a 100644
--- a/drivers/staging/vc04_services/interface/TODO
+++ b/drivers/staging/vc04_services/interface/TODO
@@ -16,23 +16,6 @@ some of the ones we want:
   to manage these buffers as dmabufs so that we can zero-copy import
   camera images into vc4 for rendering/display.
 
-2) Garbage-collect unused code
-
-One of the reasons this driver wasn't upstreamed previously was that
-there's a lot code that got built that's probably unnecessary these
-days.  Once we have the set of VCHI-using drivers we want in tree, we
-should be able to do a sweep of the code to see what's left that's
-unused.
-
-3) Make driver more portable
-
-Building this driver with arm/multi_v7_defconfig or arm64/defconfig
-leads to data corruption during the following command:
-
-  vchiq_test -f 1
-
-This should be fixed.
-
 4) Fix kernel module support
Hi Greg,
Now the numbering is out of order?
It was already out of order (No point 11). I assumed it was so that references to the
tasks nos in discussion that took place before this patch will make sense.
How about a first patch to remove the numbering and just replace it with
a list of items that are not numbered, and then remove the tasks that
are already done?
Sure I can do that.

Thanks for the review.
ojaswin
thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help