Thread (4 messages) 4 messages, 4 authors, 2021-09-27

[PATCH] avoid crashing the kernel

From: Michael Estner <hidden>
Date: 2021-09-25 20:04:50
Also in: lkml
Subsystem: most(r) technology driver, staging subsystem, the rest · Maintainers: Parthiban Veerasooran, Christian Gromm, Greg Kroah-Hartman, Linus Torvalds

To avoid chrashing the kernel I use WARN_ON instead.

Signed-off-by: Michael Estner <redacted>
---
 drivers/staging/most/i2c/i2c.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/i2c/i2c.c b/drivers/staging/most/i2c/i2c.c
index 7042f10887bb..e1edd892f9fd 100644
--- a/drivers/staging/most/i2c/i2c.c
+++ b/drivers/staging/most/i2c/i2c.c
@@ -68,7 +68,7 @@ static int configure_channel(struct most_interface *most_iface,
 	struct hdm_i2c *dev = to_hdm(most_iface);
 	unsigned int delay, pr;

-	BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
+	WARN_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);

 	if (channel_config->data_type != MOST_CH_CONTROL) {
 		pr_err("bad data type for channel %d\n", ch_idx);
@@ -122,7 +122,7 @@ static int enqueue(struct most_interface *most_iface,
 	struct hdm_i2c *dev = to_hdm(most_iface);
 	int ret;

-	BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
+	WARN_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);

 	if (ch_idx == CH_RX) {
 		/* RX */
@@ -167,7 +167,7 @@ static int poison_channel(struct most_interface *most_iface,
 	struct hdm_i2c *dev = to_hdm(most_iface);
 	struct mbo *mbo;

-	BUG_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);
+	WARN_ON(ch_idx < 0 || ch_idx >= NUM_CHANNELS);

 	if (ch_idx == CH_RX) {
 		if (!polling_rate)
--
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help