# Re: \[PATCH v8 04/19\] staging: r8188eu: reorder comments in usbctrl\_vendorreq()

- From: Greg Kroah-Hartman \<gregkh@linuxfoundation.org\>
- Date: 2021-09-20 11:48:15 
- List: linux-staging
- Page: https://ratatoskr.run/linux-staging/2021/09/1514528
- Thread: https://ratatoskr.run/linux-staging/2021/09/1514201/t.md

```text
On Mon, Sep 20, 2021 at 01:53:41AM +0200, Fabio M. De Francesco wrote:
> Reorder comments in usbctrl_vendorreq() to follow the Linux style.
> 
> Co-developed-by: Pavel Skripkin <redacted>
> Signed-off-by: Pavel Skripkin <redacted>
> Signed-off-by: Fabio M. De Francesco <redacted>
> ---
>  drivers/staging/r8188eu/hal/usb_ops_linux.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> index d92bdcc3716d..9138b730490f 100644
> --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> @@ -35,9 +35,11 @@ static int usbctrl_vendorreq(struct intf_hdl *intfhdl, u16 value, void *data, u1
>  	io_buf = dvobjpriv->usb_vendor_req_buf;
>  
>  	if (requesttype == REALTEK_USB_VENQT_READ)
> -		pipe = usb_rcvctrlpipe(udev, 0);/* read_in */
> +		/* read in */
> +		pipe = usb_rcvctrlpipe(udev, 0);
>  	else
> -		pipe = usb_sndctrlpipe(udev, 0);/* write_out */
> +		/* write out */
> +		pipe = usb_sndctrlpipe(udev, 0);

For single-line if statements, that's not really needed.  Just drop the
comments entirely, the code here is "obvious".

thanks,

greg k-h
```