[PATCH] staging: r8188eu: Add spaces before and after logical '&'

Subsystems: staging subsystem, the rest

STALE1821d

2 messages, 2 authors, 2021-08-17 · open the first message on its own page

[PATCH] staging: r8188eu: Add spaces before and after logical '&'

From: Abhishek Anand Kulkarni <hidden>
Date: 2021-08-17 02:26:43

Fix Checkpatch.pl warning to add space before and after logical '&'
operator

Signed-off-by: Abhishek Anand Kulkarni <redacted>
---
 drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
index a7f966a..570f25f 100644
--- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
+++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
@@ -630,7 +630,7 @@ u8 rtw_set_802_11_add_key(struct adapter *padapter, struct ndis_802_11_key *key)
 		struct ndis_802_11_wep *wep = &padapter->securitypriv.ndiswep;
 
 		wep->Length = len;
-		keyindex = key->KeyIndex&0x7fffffff;
+		keyindex = key->KeyIndex & 0x7fffffff;
 		wep->KeyIndex = keyindex ;
 		wep->KeyLength = key->KeyLength;
 
-- 
2.7.4

Re: [PATCH] staging: r8188eu: Add spaces before and after logical '&'

From: Michael Straube <hidden>
Date: 2021-08-17 06:55:06

On 8/17/21 4:26 AM, Abhishek Anand Kulkarni wrote:
quoted hunk
Fix Checkpatch.pl warning to add space before and after logical '&'
operator

Signed-off-by: Abhishek Anand Kulkarni <redacted>
---
  drivers/staging/r8188eu/core/rtw_ioctl_set.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
index a7f966a..570f25f 100644
--- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
+++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
@@ -630,7 +630,7 @@ u8 rtw_set_802_11_add_key(struct adapter *padapter, struct ndis_802_11_key *key)
  		struct ndis_802_11_wep *wep = &padapter->securitypriv.ndiswep;
  
  		wep->Length = len;
-		keyindex = key->KeyIndex&0x7fffffff;
+		keyindex = key->KeyIndex & 0x7fffffff;
  		wep->KeyIndex = keyindex ;
  		wep->KeyLength = key->KeyLength;
  
Hi Abhishek,

there is already a pending patch that addresses this.

https://lore.kernel.org/linux-staging/20210816155818.24005-9-straube.linux@gmail.com/T/#u

Regards,
Michael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help