# Re: \[PATCH v2 4/4\] bus: Make remove callback return void

- From: Thorsten Scherer \<t.scherer@eckelmann.de\>
- Date: 2021-07-07 21:52:08 
- List: linux-staging
- Page: https://ratatoskr.run/linux-staging/2021/07/1436004
- Thread: https://ratatoskr.run/linux-mips/2021/07/1434856/t.md

```text

On Tue, Jul 06, 2021 at 05:48:03PM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
> 
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
> 
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.

[...]

>  drivers/siox/siox-core.c                  | 4 +---

(For drivers/siox)

Acked-by: Thorsten Scherer <t.scherer@eckelmann.de>

Best regards
Thorsten

--
Thorsten Scherer | Eckelmann AG | www.eckelmann.de |
```