[PATCH] media: atomisp: Replace whitespace at the beginning of line

Subsystems: intel mid (mobile internet device) platform, media input infrastructure (v4l/dvb), staging - atomisp driver, staging subsystem, the rest

STALE1899d

2 messages, 2 authors, 2021-05-24 · open the first message on its own page

[PATCH] media: atomisp: Replace whitespace at the beginning of line

From: Aniket Bhattacharyea <hidden>
Date: 2021-05-20 15:51:19

This patch replaces the whitespaces at the beginning of line with tabs.
Identified by checkpatch: WARNING: please, no spaces at the start of a line.

Signed-off-by: Aniket Bhattacharyea <redacted>
---
 drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
index 135994d44802..93ac7e183344 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c

@@ -1041,9 +1041,9 @@ static struct camera_sensor_platform_data acpi_gmin_plat = {
 };
 
 struct camera_sensor_platform_data *gmin_camera_platform_data(
-    struct v4l2_subdev *subdev,
-    enum atomisp_input_format csi_format,
-    enum atomisp_bayer_order csi_bayer)
+	struct v4l2_subdev *subdev,
+	enum atomisp_input_format csi_format,
+	enum atomisp_bayer_order csi_bayer)
 {
 	u8 pmic_i2c_addr = gmin_detect_pmic(subdev);
 	struct gmin_subdev *gs;

-- 
2.31.1

Re: [PATCH] media: atomisp: Replace whitespace at the beginning of line

From: Sakari Ailus <sakari.ailus@linux.intel.com>
Date: 2021-05-24 15:28:35

Hi Aniket,

On Thu, May 20, 2021 at 09:20:13PM +0530, Aniket Bhattacharyea wrote:

quoted hunk

This patch replaces the whitespaces at the beginning of line with tabs.
Identified by checkpatch: WARNING: please, no spaces at the start of a line.

Signed-off-by: Aniket Bhattacharyea <redacted>
---
 drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
index 135994d44802..93ac7e183344 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c

@@ -1041,9 +1041,9 @@ static struct camera_sensor_platform_data acpi_gmin_plat = {
 };
 
 struct camera_sensor_platform_data *gmin_camera_platform_data(
-    struct v4l2_subdev *subdev,
-    enum atomisp_input_format csi_format,
-    enum atomisp_bayer_order csi_bayer)
+	struct v4l2_subdev *subdev,
+	enum atomisp_input_format csi_format,
+	enum atomisp_bayer_order csi_bayer)

Please wrap instead after the type if the type and name are too long.

I.e.

struct camera_sensor_platform_data *
gmin_camera_platform_data(...,
			  ...);

 {
 	u8 pmic_i2c_addr = gmin_detect_pmic(subdev);
 	struct gmin_subdev *gs;

-- 
Regards,

Sakari Ailus

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help