Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface
From: Mark Brown <hidden>
Date: 2014-10-28 14:58:50
Also in:
alsa-devel, linux-arm-kernel, linux-fbdev, linux-gpio, linux-input, linux-leds
Possibly related (same subject, not in this thread)
- 2014-11-01 · Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Alexandre Courbot <hidden>
- 2014-10-31 · Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Dmitry Eremin-Solenikov <hidden>
- 2014-10-31 · Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Linus Walleij <hidden>
- 2014-10-28 · Re: [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Dmitry Eremin-Solenikov <hidden>
- 2014-10-28 · [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface · Dmitry Eremin-Solenikov <hidden>
On Tue, Oct 28, 2014 at 03:02:04AM +0300, Dmitry Eremin-Solenikov wrote:
Since LoCoMo driver has been converted to provide proper gpiolib interface, make poodle ASoC platform driver use gpiolib API.
Please use subject lines matching the style for the subsystem.
+ ret = gpio_request_array(poodle_gpios, ARRAY_SIZE(poodle_gpios));
+ if (ret) {
+ dev_err(&pdev->dev, "gpio_request_array() failed: %d\n",
+ ret);
+ return ret;
+ }I sense a need for devm_gpio_request_array() here. Otherwise this looks fine - ideally it'd move to gpiod but moving to gpiolib is a clear win so no need to block on this. Acked-by: Mark Brown <redacted> with at least the subject line fixed.
Attachments
- signature.asc [application/pgp-signature] 473 bytes