Thread (27 messages) 27 messages, 5 authors, 2012-10-23

Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory

From: Wen Congyang <hidden>
Date: 2012-10-20 01:47:45
Also in: linux-acpi, linux-mm, linux-s390, linuxppc-dev, lkml, sparclinux

At 10/20/2012 02:33 AM, KOSAKI Motohiro Wrote:
quoted
I think it again, and found that this check is necessary. Because we only
lock memory hotplug when offlining pages. Here is the steps to offline and
remove memory:

1. lock memory hotplug
2. offline a memory section
3. unlock memory hotplug
4. repeat 1-3 to offline all memory sections
5. lock memory hotplug
6. remove memory
7. unlock memory hotplug

All memory sections must be offlined before removing memory. But we don't
hold
the lock in the whole operation. So we should check whether all memory
sections
are offlined before step6.
You should describe the race scenario in the patch description. OK?
OK

Thanks
Wen Congyang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help