# Re: \[PATCH v6 11/13\] serial: 8250\_dw: add Ambarella CV75 quirks

- From: Linus Walleij \<linusw@kernel.org\>
- Date: 2026-09-04 22:45:17 
- List: linux-serial
- Page: https://ratatoskr.run/linux-serial/2026/09/17517166
- Thread: https://ratatoskr.run/sashiko-reviews/2026/09/17517166/t.md

```text
On Fri, Sep 4, 2026 at 8:51 AM [ref] wrote:

> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:

> New issues:
> - [High] Eagerly writing to UART_IER in the startup callback prematurely enables RX interrupts and races with the console lock.

> > +     /*
> > +      * Ambarella keeps variant IER bits (e.g. ETOI) set for correct RX
> > +      * timeout behaviour. Force them into the 8250 IER shadow so later
> > +      * generic IER updates do not clear them.
> > +      */
> > +     up->ier |= d->pdata->ier_mask;
> > +     serial_port_out(p, UART_IER, up->ier);
>
> [Severity: High]
> Does this eager write to UART_IER race with the console lock or risk causing
> an interrupt storm?

That looks like a non-issue to me: the comment explicitly says
what this is about and it's not enabling any interrupts... pretty much
the revers of what Sashiko says could happen is happening, right?
It is actually *disabling* all interrupts.

Yours,
Linus Walleij
```
