Re: Re: [PATCH v3] serial: pch_uart: potential dereference of null pointer

On Mon, Dec 20, 2021 at 11:37:58AM +0800, Greg KH wrote:

This patch is obviously not correct, and will cause problems if it were
accepted.

Please work on whatever tool you are using to find and make these
changes, as it is not working properly.

Or, if this was a manual change, please work on your kernel programming
skills.  There are a number of bugs in this proposed change, showing
that it was not tested at all.

Sorry, I am not so familiar with the kernel and I really change the code manually.
Could you please tell me what's wrong with my patch with more details?
And I just find that I may forget to release the chan.
Is that all?
Or there are other bugs I need to deal with.

Sincerely thanks,
Jiasheng