[PATCH v3] serial: liteuart: Fix NULL pointer dereference in ->remove()
From: Ilia Sergachev <hidden>
Date: 2021-11-15 22:51:23
Subsystem:
litex platform, the rest, tty layer and serial drivers · Maintainers:
Karol Gugala, Mateusz Holenko, Gabriel Somlo, Joel Stanley, Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby
drvdata has to be set in _probe() - otherwise platform_get_drvdata()
causes null pointer dereference BUG in _remove().
Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Ilia Sergachev <redacted>
---
v2 -> v3: update subject and description
v1 -> v2: add Fixes:
drivers/tty/serial/liteuart.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
index dbc0559a9157..f075f4ff5fcf 100644
--- a/drivers/tty/serial/liteuart.c
+++ b/drivers/tty/serial/liteuart.c@@ -285,6 +285,8 @@ static int liteuart_probe(struct platform_device *pdev) port->line = dev_id; spin_lock_init(&port->lock); + platform_set_drvdata(pdev, port); + return uart_add_one_port(&liteuart_driver, &uart->port); }
--
2.25.1